Simplify SubscriptionConnection #719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
SubscriptionConnection
was a stream ofGraphQLResponse<'a, S>
, a newtype for:This doesn't really make much sense because subscription events cannot have any sort of pre-execution errors and the
GraphQLResponse
is alwaysOk
. This is a bit misleading and complicates lifetimes as the output of the stream can otherwise be'static
.This PR just makes
SubscriptionConnection
a stream of unwrapped tuples. This has the added benefit of allowing the user of the API to actually access the data / errors before serializing. Alternatively, it might make sense to create a new type for this, e.g. anExecutionResult
type.This is something I came across while working on #709 that I figured could go in its own PR.