Simplify code with better base classes #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Deduplicate code
It'll still cause an exception on .execute() if somehow a third party subscription server did the wrong thing anyway
Also remove iteratable operations from the context when they complete
|
This is a mega-fix, worthy of a new major release number - both for the fact that it's a large rewrite, and because of the size it may have unknowingly introduced some backwards incompatibilities. I really can't see a good way to refactor this into a smaller set of patches, and I know that it will be a mare to review... I'm using it as the new basis of the channels2 code, being used in a preproduction environment, so the django 2 code works at least :P My hope is that since the project has stagnated so long, we can just push this sooner rather than delay it forever and actually get some more eyes looking at it. |
…plicitly returned
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicate code, providing separate sync and async base classes with the common code that was duplicated across backends hoisted back to these bases.
In abstracting this code, it allowed for fixing changes that had been only applied against one application server across the board. Some more fixes were introduced to.
This should fix #24, #22, #19, #10, #48, #16, #12, #8, #7