Skip to content

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented May 7, 2020

References #34, this PR merges sanic-graphql library into graphql-server-core.

To install the integration with sanic, run the below command on your terminal.
pip install graphql-server-core[sanic]

NOTE The only main issue so far is dealing with the asyncio executor tests.

@KingDarBoja KingDarBoja added the type: feature A new feature label May 7, 2020
@KingDarBoja KingDarBoja requested a review from jkimbo May 7, 2020 04:50
@KingDarBoja KingDarBoja self-assigned this May 7, 2020
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @KingDarBoja . Whats left to do?

@KingDarBoja KingDarBoja force-pushed the merge-sanic-graphql branch from 7e418f1 to 5c79d33 Compare May 10, 2020 19:11
@KingDarBoja KingDarBoja marked this pull request as ready for review May 10, 2020 21:46
@KingDarBoja KingDarBoja requested a review from jkimbo May 10, 2020 21:49
This was referenced May 16, 2020
@KingDarBoja KingDarBoja requested a review from Cito June 2, 2020 23:07
@KingDarBoja KingDarBoja merged commit 35ed87d into graphql-python:master Jun 6, 2020
@KingDarBoja KingDarBoja deleted the merge-sanic-graphql branch June 6, 2020 16:40
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants