Switch operation_name to operationName in GraphQLTestCase
#936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkimbo
approved these changes
Apr 19, 2020
Member
jkimbo
left a comment
jkimbo
left a comment
There was a problem hiding this comment.
Good find! Looks like this was a bug because the GraphQLView only looks for operationName:
graphene-django/graphene_django/views.py
Line 323 in 23b6419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for serving GraphQL over HTTP recommends that the operation name be specified by an
operationNameparameter.The
GraphQLTestCase.query()method ends up creating a request that uses snake_caseoperation_nameinstead. This PR addresses that.I wasn't sure how to write a complete test for this using GraphQLTestCase itself since it requires a database, so I settled for just testing the arguments that were used for
Client.post().