Skip to content

Conversation

@fneitzel
Copy link
Contributor

@fneitzel fneitzel commented Apr 2, 2020

Add some information about GRAPHQL_URL. Otherwise people run into ERROR 400 problems, if they have a different endpoint.

Add some information about GRAPHQL_URL. Otherwise people run into ERROR 400 problems, if they have a different endpoint.
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fneitzel . Small suggestion otherwise this looks good.

docs/testing.rst Outdated

If you want to unittest your API calls derive your test case from the class `GraphQLTestCase`.

Your endpoint is set with `GRAPHQL_URL`. The default endpoint is `GRAPHQL_URL="/graphql/"` in `GraphQLTestCase`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Your endpoint is set with `GRAPHQL_URL`. The default endpoint is `GRAPHQL_URL="/graphql/"` in `GraphQLTestCase`
Your endpoint is set through the `GRAPHQL_URL` attribute on `GraphQLTestCase`. The default endpoint is `GRAPHQL_URL = "/graphql/"`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds correct now ;)

Co-Authored-By: Jonathan Kim <[email protected]>
@jkimbo jkimbo merged commit b84f61a into graphql-python:master Apr 6, 2020
@jkimbo
Copy link
Member

jkimbo commented Apr 6, 2020

Thanks @fneitzel !

@fneitzel fneitzel deleted the patch-1 branch April 6, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants