Adding Django filter as an installed app #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@RoySegall It may be a good idea to also mention it in the docs on Filtering. Docs mention cookbook itself, but not everyone is going to check that out. |
Contributor
Author
Well.. I did 😁. Any way, the docs you mentioned located in here, right? |
Contributor
https://github.com/graphql-python/graphene-django/blob/master/docs/filtering.rst |
Contributor
Author
|
10x! I'll update it later on this week. |
jkimbo
approved these changes
Apr 6, 2020
Member
jkimbo
left a comment
jkimbo
left a comment
There was a problem hiding this comment.
Thanks @RoySegall ! If you have time to update the docs as well that would be great.
Contributor
Author
|
@jkimbo Will do, on my todo list - right after Passover. Have a great day and stay at home! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to figure out how to filter results I came across the reference to the cookbook but there was missing a section that shows that we need to register the app we installed (Django-filters).
Hope this will be useful for me as for others as well.