Skip to content

AIOHTTPTransport ignore backend mimetype #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 20, 2021
Merged

AIOHTTPTransport ignore backend mimetype #248

merged 9 commits into from
Oct 20, 2021

Conversation

mirkan1
Copy link
Contributor

@mirkan1 mirkan1 commented Oct 11, 2021 •
edited by leszekhanusz
Loading

Fixes issues #246

@mirkan1 mirkan1 mentioned this pull request Oct 11, 2021
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #248 (cb994fd) into master (3db7a86) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1240      1240           
=========================================
  Hits          1240      1240
Impacted Files Coverage Δ
gql/transport/aiohttp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db7a86...cb994fd. Read the comment docs.

@leszekhanusz
Copy link
Collaborator

Also for your info, you don't need to create another PR, you could just have modified the existing one with another commit.

@mirkan1
Copy link
Contributor Author

mirkan1 commented Oct 12, 2021

when you can launch new version with this lines?

mirkan1
mirkan1 commented Oct 14, 2021
View reviewed changes
@leszekhanusz leszekhanusz changed the title tansport aiohttp transport, single line change. ignore backend mimetype AIOHTTPTransport ignore backend mimetype Oct 20, 2021
@leszekhanusz leszekhanusz merged commit 7992721 into graphql-python:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszekhanusz leszekhanusz leszekhanusz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirkan1 @codecov-commenter @leszekhanusz