Skip to content

websockets transport - optional variables and operation name #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2020
Merged

websockets transport - optional variables and operation name #111

merged 3 commits into from
Jul 10, 2020

Conversation

jsbroks
Copy link
Contributor

@jsbroks jsbroks commented Jul 6, 2020 •
edited
Loading

Fixes #101 for websockets

@coveralls
Copy link

coveralls commented Jul 6, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling ce9f233 on jsbroks:patch-2 into 140547d on graphql-python:master.

@jsbroks jsbroks closed this Jul 8, 2020
@jsbroks jsbroks deleted the patch-2 branch July 8, 2020 23:51
@jsbroks jsbroks restored the patch-2 branch July 8, 2020 23:55
@jsbroks jsbroks reopened this Jul 8, 2020
@leszekhanusz leszekhanusz changed the title Fix variable errors for websockets websockets transport - optional variables and operation name Jul 10, 2020
@leszekhanusz
Copy link
Collaborator

@jsbroks Thank you for your PR

@leszekhanusz leszekhanusz merged commit faadac4 into graphql-python:master Jul 10, 2020
@KingDarBoja KingDarBoja added type: bug An issue or pull request relating to a bug type: tests Adding missing or correcting existing tests labels Jul 10, 2020
@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jul 10, 2020
@jsbroks jsbroks deleted the patch-2 branch July 10, 2020 14:04
@jsbroks
Copy link
Contributor Author

jsbroks commented Jul 10, 2020

@KingDarBoja When is the expected next release? 3.0.0.a2?

@KingDarBoja
Copy link
Contributor

KingDarBoja commented Jul 10, 2020 •
edited
Loading

@jsbroks I will talk to the package owners to see if we can release it this weekend. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszekhanusz leszekhanusz leszekhanusz approved these changes

Assignees
No one assigned
Labels
type: bug An issue or pull request relating to a bug type: tests Adding missing or correcting existing tests
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Invalid or incomplete introspection with async transport
4 participants
@jsbroks @coveralls @leszekhanusz @KingDarBoja