Skip to content

Update primitive type descriptions #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Update primitive type descriptions #51

merged 1 commit into from
Jan 8, 2022

Conversation

xenomachina
Copy link
Contributor

The type descriptions were previously inconsistent (eg: Long's was "Long
type", while Short's was "Short as Int"), and unhelpful to clients that
aren't familiar with Java's type system (eg: "Short" may have no meaning
to a JavaScript programmer, nor would "java.math.BigInteger")

This change attempts to make the descriptions more consistent and also
programming language agnostic.

The type descriptions were previously inconsistent (eg: Long's was "Long
type", while Short's was "Short as Int"), and unhelpful to clients that
aren't familiar with Java's type system (eg: "Short" may have no meaning
to a JavaScript programmer, nor would "java.math.BigInteger")

This change attempts to make the descriptions more consistent and also
programming language agnostic.
@bbakerman
Copy link
Member

Thanks for this

@bbakerman bbakerman merged commit 9df62b5 into graphql-java:master Jan 8, 2022
@xenomachina xenomachina deleted the primitive-type-descriptions branch January 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants