add beforeQueryHelper

[antoniopresto]

I'll update tests, for now, is this acceptable?

I need beforeQuery to handle custom user/regions/etc rules.

[nodkz]

I'll try to review it after several hours.

I had a fast look and your improvement quite interesting 👍

[nodkz]

Yep, graphql-compose-mongoose needs in this changes 👍🔥 My thoughts

1) I think that we need to pass mongoose model to

- const res = await beforeQueryHelper(resolveParams).exec();
+ const res = await beforeQueryHelper(resolveParams, model).exec();

It helps to recreate query from scratch, make additional queries, check what models are using for cases when one beforeQuery are used for different models.

2) We need to hide exec() in beforeQueryHelper

It helps mock results or return data from other sources eg cache.

- const res = await beforeQueryHelper(resolveParams, model).exec();
+ const res = await beforeQueryHelper(resolveParams, model);

PS. Count resolver should be rewritten.

- resolveParams.query = model.find();
- return beforeQueryHelper(resolveParams)
-          .countDocuments()
-          .exec();
+ resolveParams.query = model.countDocuments();
+ return beforeQueryHelper(resolveParams, model)

await UserModel.countDocuments().where({ name: 'userName2' }) works perfectly (firstly applies where condition then makes count)

3) Tests, need more tests )

[antoniopresto]

Nice! Thanks for the quick response. I'll take a look at this right now

[antoniopresto]

Hi @nodkz! Do you see any disadvantages in put the model in ExtendedResolveParams?

[nodkz]

@antoniopresto Yep, put the model to ExtendedResolveParams. I wanted to suggest the same solution.

[antoniopresto]

implemented more tests :) I think its complete

[nodkz]

Nice👍 didn't know such spying way

[antoniopresto]

discovered this week haha

[nodkz]

Forgot to remove second arg (model)?
All resolvers affected.

[antoniopresto]

nice catch :)

[nodkz]

Great work! 👍
After removing model I'm ready to merge. But can do it only tomorrow (in 9 hours).

PS. Any example in readme will be very appreciated but not obligatory.

[antoniopresto]

Thanks! Your work is inspiring. I can try to help with the readme, but my english doesn't help much hehe

[nodkz]

Very cool PR! Thanks! 🙏

[nodkz]

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀