Skip to content

Conversation

wind0r
Copy link

@wind0r wind0r commented Sep 22, 2025

It would also be great to be able to add extra annotations to the headless service.
We want to use this to add external dns settings to the headless service for ingest path.

tested with:
Single Binary:

helm template pyroscope . \
  --set pyroscope.components.ingester.service.headlessAnnotations."istio\.io/rev"="stable"

Microservices

helm template pyroscope . \
  --values values-micro-services.yaml \
  --set pyroscope.components.ingester.service.headlessAnnotations."istio\.io/rev"="stable"

@wind0r wind0r requested a review from a team as a code owner September 22, 2025 16:55
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wind0r wind0r force-pushed the add_extra_annotations_to_headless_service branch from 1757355 to aef5e79 Compare September 25, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants