chore: TODO cleanup: use buffer pool instead of generic #4437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-kozlyuk-grafana
requested review from
alsoba13 and
a team
as code owners
| } | ||
|
|
||
| blockFile := bufferpool.GetBuffer(len(stream.heads) * 2 / 1024) // rough estimate, 2kb per head | ||
| blockFile := bufferpool.GetBuffer(2 * 1024) // reserve extra to avoid resizes |
There was a problem hiding this comment.
Should we maybe remember the size of the buffer between flushes?
Also 2k is likely too short
Not sure if you have access https://ops.grafana-ops.net/goto/bey8h9q72mu4gd?orgId=1
Do you know why was it divided by 1024? Was it a bug?
There was a problem hiding this comment.
The division was a typo - sorry about that, already fixed before comment.
Good point about buffer size - I tried to take a safe route, but it looks like - esp. considering how bufferpool works - it won't work. Will rethink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.