feat: Add Rule Name and Type to Query Tags #15055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chaudum
reviewed
Dec 9, 2024
cstyan
force-pushed
the
benton/ruler-tags
branch
from
5e6e50b to
9694522
Compare
insights within grafana cloud for grafana cloud logs users Signed-off-by: Callum Styan <[email protected]>
cstyan
force-pushed
the
benton/ruler-tags
branch
from
9694522 to
0356675
Compare
Signed-off-by: Callum Styan <[email protected]>
executing the query (includes the response not being JSON, which would result in there being no query statistics struct) Signed-off-by: Callum Styan <[email protected]>
logging to insights logs Signed-off-by: Callum Styan <[email protected]>
chaudum
approved these changes
Jan 10, 2025
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the ruler evaluation is remote, the only query tag set is
source=ruler. When identifying problematic queries it would be more useful to have more than just thequeryandsource=ruler. This adds support to also set therule_nameandrule_type.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Eventually, we may need to add
namespaceandgroupChecklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR