Grafana builder: use $__rate_interval over $__interval #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bergquist <[email protected]>
bergquist
commented
Dec 14, 2020
| targets: [ | ||
| { | ||
| expr: 'histogram_quantile(0.99, sum(rate(%s_bucket%s[$__interval])) by (le)) * %s' % [metricName, selector, multiplier], | ||
| expr: 'histogram_quantile(0.99, sum(rate(%s_bucket%s[$__rate_interval])) by (le)) * %s' % [metricName, selector, multiplier], |
Contributor
Author
There was a problem hiding this comment.
I've never used histogram_quantile so I dont know if this makes sense.. But I dont see why It wouldn't 🤷♂️
Contributor
|
When was rate_interval introduced? This will break people on old Grafana IIUC. Just want to make sure old in this context doesn't mean "last week". |
Contributor
Author
|
It was introduced in Grafana 7.2.0 released (2020-09-23) |
Contributor
|
Awesome, thanks Carl. I'll leave it to you to judge if 3 months is enough - this library is used by the k8s mixin, which is included in the kube-prometheus, which embeds grafana/grafana:7.3.5 in head (see https://github.com/prometheus-operator/kube-prometheus/blob/master/manifests/grafana-deployment.yaml). So I'd say LGTM |
Contributor
Author
|
3 months in mixin lands is how many human years? |
bboreham
added a commit
to grafana/cortex-jsonnet
that referenced
this pull request
Aug 18, 2021
Brings in the following changes: - Use default as a picker value for datasource variable grafana/jsonnet-libs#204 - allow table link in new tab grafana/jsonnet-libs#238 - allow setting a default datasource grafana/jsonnet-libs#301 - Add textPanel grafana/jsonnet-libs#341 - make status code label name overrideable in qpsPanel grafana/jsonnet-libs#397 - use $__rate_interval over $__interval grafana/jsonnet-libs#401 - Set shared tooltip to false by default grafana/jsonnet-libs#458 - Use custom 'all' value to avoid massive regexes in queries. grafana/jsonnet-libs#469 https://github.com/grafana/jsonnet-libs/commits/master/grafana-builder/
1 task
bboreham
added a commit
to grafana/cortex-jsonnet
that referenced
this pull request
Aug 18, 2021
Brings in the following changes: - Use default as a picker value for datasource variable grafana/jsonnet-libs#204 - allow table link in new tab grafana/jsonnet-libs#238 - allow setting a default datasource grafana/jsonnet-libs#301 - Add textPanel grafana/jsonnet-libs#341 - make status code label name overrideable in qpsPanel grafana/jsonnet-libs#397 - use $__rate_interval over $__interval grafana/jsonnet-libs#401 - Set shared tooltip to false by default grafana/jsonnet-libs#458 - Use custom 'all' value to avoid massive regexes in queries. grafana/jsonnet-libs#469 https://github.com/grafana/jsonnet-libs/commits/master/grafana-builder/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bergquist [email protected]