fix(signal): No longer aggregates histogram signals after histogram_quantile #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uantile() as it is pointless aggregation. Aggregation before applying histogram_quantile() is kept and works as expected
Dasomeone
previously approved these changes
Oct 23, 2025
| @@ -1,3 +1,7 @@ | |||
| # 0.4.3 | |||
There was a problem hiding this comment.
Surely should just be 0.4.1? :)
Suggested change
| # 0.4.3 | |
| # 0.4.1 |
There was a problem hiding this comment.
Oh my apologies, I reviewed these in backwards order, will undo
Dasomeone
dismissed
their stale review
Wrong review order. Will reconcile in-order
Dasomeone
reviewed
Oct 23, 2025
Dasomeone
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(signal): No longer aggregates histogram signals after histogram_quantile() as it is pointless aggregation (average of quantiles etc...).
Aggregation before applying histogram_quantile() is kept and works as expected.