chore: Modernize the Presto Mixin #1491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dasomeone
reviewed
Oct 16, 2025
Comment on lines
+114
to
+140
| coordinatorNonheapMemoryUsage: | ||
| g.panel.gauge.new('Non-heap memory usage') | ||
| + g.panel.gauge.queryOptions.withTargets(signals.coordinator.nonheapMemoryUsage.asTarget()) | ||
| + g.panel.gauge.panelOptions.withDescription('Non-heap memory usage') | ||
| + g.panel.gauge.standardOptions.withUnit('percentunit') | ||
| + g.panel.gauge.standardOptions.thresholds.withSteps([ | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-green') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('#EAB839') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.7), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-red') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.8), | ||
| ]), | ||
|
|
||
| coordinatorHeapMemoryUsage: | ||
| g.panel.gauge.new('Heap memory usage') | ||
| + g.panel.gauge.queryOptions.withTargets(signals.coordinator.heapMemoryUsage.asTarget()) | ||
| + g.panel.gauge.panelOptions.withDescription('Heap memory usage') | ||
| + g.panel.gauge.standardOptions.thresholds.withSteps([ | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-green') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('#EAB839') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.7), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-red') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.8), | ||
| ]) | ||
| + g.panel.gauge.standardOptions.withUnit('percentunit'), |
There was a problem hiding this comment.
Could you update these to use the common-lib memory panels?
There was a problem hiding this comment.
@Dasomeone looking into this more, but just confirming are we moving away from the gauge panel here in favor of a stat?
commonlib.panels.memory.stat.usage.new()
=>
vs
There was a problem hiding this comment.
Oh hmm that's a good point. I think there's a case to be made for either. I do prefer the gauge for this actually, so apologies for suggesting that.
I think in fact we could make a case for adding a good common-lib gauge with standard settings, so for now we can keep this as-is!
Again, apologies 😅
Dasomeone
approved these changes
Oct 24, 2025
Comment on lines
+114
to
+140
| coordinatorNonheapMemoryUsage: | ||
| g.panel.gauge.new('Non-heap memory usage') | ||
| + g.panel.gauge.queryOptions.withTargets(signals.coordinator.nonheapMemoryUsage.asTarget()) | ||
| + g.panel.gauge.panelOptions.withDescription('Non-heap memory usage') | ||
| + g.panel.gauge.standardOptions.withUnit('percentunit') | ||
| + g.panel.gauge.standardOptions.thresholds.withSteps([ | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-green') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('#EAB839') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.7), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-red') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.8), | ||
| ]), | ||
|
|
||
| coordinatorHeapMemoryUsage: | ||
| g.panel.gauge.new('Heap memory usage') | ||
| + g.panel.gauge.queryOptions.withTargets(signals.coordinator.heapMemoryUsage.asTarget()) | ||
| + g.panel.gauge.panelOptions.withDescription('Heap memory usage') | ||
| + g.panel.gauge.standardOptions.thresholds.withSteps([ | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-green') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('#EAB839') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.7), | ||
| g.panel.gauge.standardOptions.threshold.step.withColor('light-red') | ||
| + g.panel.gauge.standardOptions.threshold.step.withValue(0.8), | ||
| ]) | ||
| + g.panel.gauge.standardOptions.withUnit('percentunit'), |
There was a problem hiding this comment.
Oh hmm that's a good point. I think there's a case to be made for either. I do prefer the gauge for this actually, so apologies for suggesting that.
I think in fact we could make a case for adding a good common-lib gauge with standard settings, so for now we can keep this as-is!
Again, apologies 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presto overview:
Presto coordinator:
Presto worker:
Presto logs:
