Apache Mesos Mixin Modernization #1488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmikei
changed the title
…i/jsonnet-libs into chore/apache-mesos-modernization
…pache-mesos-modernization
Dasomeone
reviewed
Oct 16, 2025
| + g.panel.stat.options.withGraphMode('none') | ||
| + g.panel.stat.panelOptions.withDescription('Master uptime in seconds'), | ||
| cpusAvailablePanel: | ||
| g.panel.stat.new('CPUS available') |
There was a problem hiding this comment.
Tiny suggestion here, entirely up to you if you agree?
Suggested change
| g.panel.stat.new('CPUS available') | |
| g.panel.stat.new('CPUs available') |
| local signals = this.signals, | ||
|
|
||
| masterUptimePanel: | ||
| g.panel.stat.new('Master uptime') |
There was a problem hiding this comment.
Could you update this to use the common-lib stat panel?
Same throughout for any g.panel.stat panels
| + g.panel.stat.options.withGraphMode('none') | ||
| + g.panel.stat.panelOptions.withDescription('CPUs available in the cluster'), | ||
| memoryAvailablePanel: | ||
| g.panel.stat.new('Memory available') |
There was a problem hiding this comment.
As with the other PRs, can you update the memory panels to use the common lib approach instead of g.panel.stat?
| + g.panel.stat.panelOptions.withDescription('GPUs available in the cluster'), | ||
|
|
||
| diskAvailablePanel: | ||
| g.panel.stat.new('Disk available') |
There was a problem hiding this comment.
Similarly for all the disk panels, we have common-lib` disk panels https://github.com/grafana/jsonnet-libs/tree/master/common-lib/common/panels/disk that would be great to use
Comment on lines
+28
to
+29
|
|
||
|
|
Comment on lines
+37
to
+38
|
|
||
|
|
Comment on lines
+5
to
+12
| local mixin = mixinlib.new() | ||
| + mixinlib.withConfigMixin( | ||
| { | ||
| filteringSelecter: config.filteringSelector, | ||
| uid: config.uid, | ||
| enableLokiLogs: true, | ||
| } | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Apache Mesos mixin to use commonlib and g.libsonnet
Apache Mesos overview
Apache Mesos logs overview
Improvement to sample app: grafana/integration-sample-apps#72