feat(opentelemetry-collector): Add new alerts and enhance configuration #1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: @tpaschalis |
Dasomeone
previously approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Sorry for the delay on this one @alex5517!
No functional issues, but mixtool is throwing some lint errors that you may want to address :)
$ mixtool lint mixin.libsonnet
[alert-summary-missing-rule] Alert 'ReceiverDroppedSpans' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'ReceiverDroppedMetrics' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'ReceiverDroppedLogs' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'ExporterDroppedSpans' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'ExporterDroppedMetrics' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'ExporterDroppedLogs' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'ExporterQueueSize' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'SendQueueFailedSpans' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'SendQueueFailedMetricPoints' must have annotation 'summary'
[alert-summary-missing-rule] Alert 'SendQueueFailedLogRecords' must have annotation 'summary'
[template-datasource-rule] 'OpenTelemetry Collector / Operational': Dashboard 'OpenTelemetry Collector / Operational' templated data source variable named 'default', should be named 'prometheus_datasource', or 'datasource'
2025/10/16 14:57:30 failed to lint the file mixin.libsonnet: 11 lint errors found
|
Hi @Dasomeone, I fixed the lint errors :) |
|
Aside apparently from a jsonnet formatting error 😅 Could you run |
Signed-off-by: Alexander Soelberg Heidarsson <[email protected]>
|
@Dasomeone - Argh, sorry about that... make fmt changes pushed. |
…libs into feat/add-rules-otelcol
postnati
pushed a commit
to postnati/jsonnet-libs
that referenced
this pull request
Oct 27, 2025
…on (grafana#1486) * feat: Add new alerts and enhance configuration * feat: add alert summaries and update default datasource name * jsonnetfmt Signed-off-by: Alexander Soelberg Heidarsson <[email protected]> --------- Signed-off-by: Alexander Soelberg Heidarsson <[email protected]> Co-authored-by: Emily <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Prometheus alerts from the OpenTelemetry Collector Helm chart and modifies the config to allow for multi-cluster dashboard. Default has been configured to disabled.