chore: Aerospike Mixin Modernization #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ikei/jsonnet-libs into chore/aerospike-mixin-modernization
Dasomeone
reviewed
Sep 1, 2025
| unit: 'none', | ||
| sources: { | ||
| prometheus: { | ||
| expr: 'sum by(job, aerospike_cluster, instance) (aerospike_namespace_ns_cluster_size{%(queriesSelector)s})', |
There was a problem hiding this comment.
Same comment as on other PRs on whether we want to have a selector for sum (and others?)
I'm generally in favour, but if you have strong concerns I'm good to leave it as-is
There was a problem hiding this comment.
Ah I think I caught on within my recent commit in #1454, seems like a great idea for extensibility :) I'll go ahead and make similar changes here shortly for this PR 👍
… instanceLabels, improve legend re-usage where appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modernizes the aerospike mixin to use signals and commonlib to hopefully provide a more maintainable mixin for the future.
Throughout this we have also added support for some breaking changes around Aerospike 7.0+ versions which removed a couple of prometheus metrics that this mixin relied upon:
https://aerospike.com/docs/database/reference/metrics#namespace__device_available_pct
https://aerospike.com/docs/database/reference/metrics#namespace__memory_free_pct
To get around this we used signals to combine the queries.
Aerospike overview
Aerospike instance overview
Aerospike namespace overview
Aerospike logs
