fix(mixin-utils): remove std.prune and use std.filter instead #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
commented
May 7, 2025
Duologic
force-pushed
the
duologic/mixin-utils-noprune
branch
2 times, most recently
from
ed91c53 to
a44d28f
Compare
pstibrany
approved these changes
May 7, 2025
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
Changes lgtm. (Could it be possible to have some tests? Don't block this PR on it though.)
The use of `std.prune(std.map())` is slow and uses a big stack, on big rulesets this can cause a 'RUNTIME ERROR: max stack frames exceeded.'. It is better to use `std.filter()` to remove an element from an array.
Duologic
force-pushed
the
duologic/mixin-utils-noprune
branch
from
c5f4fc4 to
ee07910
Compare
Duologic
commented
May 7, 2025
|
|
||
| removeAlertRuleGroup(ruleName):: { | ||
| prometheusAlerts+:: $.removeRuleGroup(ruleName), | ||
| prometheusAlerts+: $.removeRuleGroup(ruleName), |
Contributor
Author
There was a problem hiding this comment.
+: means keep visiblity as it was, so if the field was hidden upstream, then it will stay hidden. I opted for this change to avoid making the test cases more complicated.
pstibrany
reviewed
May 7, 2025
| + test.case.new( | ||
| 'removeAlertRuleGroup', | ||
| test.expect.eq( | ||
| actual=config + utils.removeAlertRuleGroup('group1'), |
Contributor
There was a problem hiding this comment.
Thank you for adding tests. This also shows how these functions are supposed to be used! That's very useful!
Duologic
commented
May 7, 2025
| ) | ||
|
|
||
| + test.case.new( | ||
| 'removeAlerts', |
Contributor
Author
There was a problem hiding this comment.
I ran all but this test case against main. This test case represents a new feature, removeAlerts now accepts an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
std.prune(std.map())is slow and uses a big stack, on bigrulesets this can cause a 'RUNTIME ERROR: max stack frames exceeded.'.
It is better to use
std.filter()to remove an element from an array.