Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Aug 7, 2020

This was added as a result of cortexproject/cortex#2985. This documents reasons why the 'sample with repeated timestamp but different value' error appears in the log.

@MichelHollands MichelHollands requested a review from a team as a code owner August 7, 2020 10:16
@MichelHollands MichelHollands reopened this Aug 7, 2020
Copy link
Contributor

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful addition to me! Found a single typo

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the playbooks! I left few comments.

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichelHollands for addressing my feedback. I left a couple of more comments.

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit a3f6be1 into master Aug 10, 2020
@MichelHollands MichelHollands deleted the add_docs_for_duplicate_messages_log_lines branch August 10, 2020 15:47
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…or_duplicate_messages_log_lines

Add playbook entry for sample with repeated timestamp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants