Skip to content

[23.0] Allow built-in periodic JFR events when using JFR API to make recordings #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2023
Merged

[23.0] Allow built-in periodic JFR events when using JFR API to make recordings #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39e7071
allow periodic events when usign API
roberttoyonaga Sep 18, 2023
572ae06
pin workflow to 5c44969947cbeff84ca9ccedc127cb6730b82415
roberttoyonaga Sep 19, 2023
7e11187
use mandrel-source-nolocalmvn
roberttoyonaga Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/mandrel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
name: "Q main M 23.0 EA"
uses: graalvm/mandrel/.github/workflows/base.yml@default
with:
build-type: "mandrel-source-nolocalmvn"
quarkus-version: "main"
repo: ${{ github.repository }}
version: ${{ github.ref }}
Expand All @@ -40,6 +41,7 @@ jobs:
name: "Q main M 23.0 windows EA"
uses: graalvm/mandrel/.github/workflows/base-windows.yml@default
with:
build-type: "mandrel-source-nolocalmvn"
quarkus-version: "main"
repo: ${{ github.repository }}
version: ${{ github.ref }}
Expand All @@ -49,6 +51,7 @@ jobs:
name: "Q main M 23.0 EA Java 20"
uses: graalvm/mandrel/.github/workflows/base.yml@default
with:
build-type: "mandrel-source-nolocalmvn"
quarkus-version: "main"
repo: ${{ github.repository }}
version: ${{ github.ref }}
Expand All @@ -58,6 +61,7 @@ jobs:
name: "Q main M 23.0 windows EA Java 20"
uses: graalvm/mandrel/.github/workflows/base-windows.yml@default
with:
build-type: "mandrel-source-nolocalmvn"
quarkus-version: "main"
repo: ${{ github.repository }}
version: ${{ github.ref }}
Expand Down
2 changes: 1 addition & 1 deletion substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ public static JfrManager get() {
public RuntimeSupport.Hook startupHook() {
return isFirstIsolate -> {
parseFlightRecorderLogging(SubstrateOptions.FlightRecorderLogging.getValue());
periodicEventSetup();
if (isJFREnabled()) {
periodicEventSetup();
initRecording();
}
};
Expand Down