chore: bubble up errors when downloading credential helper fails #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Donnie Adams <[email protected]>
thedadams
requested review from
StrongMonkey,
iwilltry42,
g-linville and
tylerslaton
| @@ -249,7 +252,8 @@ func (r *Runtime) Binary(ctx context.Context, tool types.Tool, _, toolSource str | |||
| return false, nil, nil | |||
| } | |||
|
|
|||
| rel, ok := getLatestRelease(tool) | |||
| // ignore the error | |||
There was a problem hiding this comment.
Any reason we need to ignore the error here, while not on the getLatestRelease method?
There was a problem hiding this comment.
The getLatestRelease is best-effort because we don't know if the tool actually has a release. So errors don't really matter....
Except for the credential helpers. We know those have releases and we expect them to be used.
StrongMonkey
approved these changes
Sep 10, 2024
drpebcak
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.