bug: speed up the openapi loading #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuildthecloud
force-pushed
the
cache-openapi
branch
2 times, most recently
from
13acb33 to
cb4913c
Compare
cloudnautique
approved these changes
May 10, 2024
rinor
reviewed
May 11, 2024
pkg/loader/github/github.go
Outdated
| @@ -37,7 +40,14 @@ func getCommitLsRemote(ctx context.Context, account, repo, ref string) (string, | |||
| return git.LsRemote(ctx, url, ref) | |||
| } | |||
|
|
|||
| // regexp to match a git commit id | |||
| var commitRegexp = regexp.MustCompile("^[a-z0-9]{40}$") | |||
There was a problem hiding this comment.
Suggested change
| var commitRegexp = regexp.MustCompile("^[a-z0-9]{40}$") | |
| var commitRegexp = regexp.MustCompile("^[a-f0-9]{40}$") |
There was a problem hiding this comment.
thanks, good catch
ibuildthecloud
force-pushed
the
cache-openapi
branch
from
cb4913c to
82ce76a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.