Fix for asset pipeline #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but now it looks like this pr just contains the removal, not the new addition in the subdir :) |
|
nice. |
Author
|
hold, running a few more tests. |
Author
|
Released asset-pipeline 1.5.2 as a result of this, found a bug in GString evaluation. |
|
wow =) but despite that bug, the fact that assets must not be placed directly under grails-app/assets remains valid? |
Author
|
correct they need to go into an organizational folder. Early in the life of asset-pipeline (long time ago) it would have allowed it. old PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR was from early on in the asset-pipeline days. We have to move the file into a subdir