Remove unnecessary console log output #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ouch embarrassing! Thanks for spotting it. It shouldn't be there for sure 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using your React wrapper for the Notification System at a project I am currently working on and try to only show one notification at most. To make this work I use the
hideNotificationaction to hide an currently displayed notification.This makes your wrapper remove the notification from the store which is correct behavior. But I recognized, that every removed notification leads to a
console.logoutput, which gets kinda annoying and really shouldn't be happening in production.So I removed this output completely in the code, if it might be important in development environment, maybe just disable it in production mode?