-
Notifications
You must be signed in to change notification settings - Fork 292
Recent migration attempt #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
> convert to direct unity call to java add signin in editor and desktop support
Fix signOut and disconnect
seems it was needed...
Fixes & Improvements
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@calumma-robert Do you interest in signing google CLA agreement? |
|
@Thaina done! |
|
Thank you very much |
Migrate ios to 7.1.0
update readme
3da1816 to
6c3c741
Compare
and i tried using only one google account on my mobile then also popup thins select account for silent login() !. Debugging is not showing any error and it simply login me both normal Sign() or Silently-Login() . my problem is Silent Login() Issue when user already Login !..... and i tried with code also for making silent login on Star() method not working !. any solution !??? or Still Development ?... or i need to implement anything manually ??... now my problem is clear !?.. Unity.package --> Silently-Login_Notworking.zip iam using Unity 6 . but in last iam getting Debug.Log("ServerAuthCode : " + authCode) ; !.. Working bit only silent login() issue !. Refer My Video --> https://youtu.be/6DQGnQv-GL0 |
|
@shiva30122 There are 3 things I can think of |
|
@shiva30122 Please investigate the https://developer.android.com/identity/sign-in/credential-manager-siwg#enable-sign-in |
|
@Thaina I'm testing your branch in my app. And I'm facing issue with discrepancies in GoogleSignInStatusCode between platforms. When I open Google Sign-In dialog in the iOS app and instead of continuing the sign-in process I press "Cancel" on account selection popup, I get GoogleSignInStatusCode with value 2 that is treated as SERVICE_VERSION_UPDATE_REQUIRED status by plugin. Seems like status codes are just different now between iOS and Android. iOS still preserves older status code with status code 2 being GoogleSignInStatusCode.Cancel. Is that something you know about and willing to fix in the branch? |
|
I would take a look and try to update the package in near future. There is many things I would like to update too. But currently now very busy though, pardon me that it may not be so soon |
Singleton in SignInHelperObject.cs Fix
ios 9.0
#28) * Adjust runtime configuration for webClientId in GoogleSignIn_Configure * Fix typo of GIDConfiguration's property
|
Hello, I'm currently integrating Google Sign-In in my Unity Android project. While checking library alignment for 16 KB page size using the recommended tooling, I found that the native-googlesignin.so file is not aligned to 16 KB, unlike the other .so libraries in the project. Alignment Check Result: Because of this misalignment, I am getting below warning on Google Play Console. Environment details: Unity Version: 6000.0.58f2 |
|
Are you really using my branch with upm? |
Yes, I am using your branch with UPM |
|
@Milan1660 Have you test by creating clean fresh project and only install EDM4U and google signin? |
Yes, I tried with new project and I am getting alignment issue in this new project. |
|
I have test build aab and upload to google play internal track with 6.0.59f2 and there was no error or warning about 16 kb page size at all |
|
Now, I am using your same code and scene in new project. With your code
Can you help me with this? |
|
That kind of error seem like a wrong setting in webclientID or fingerprint and keystore file |
|
Now working fine in Android & iOS. Thank you @Thaina. |
Refactor GoogleSignInImplEditor for silentsignin support with cache



Since there is deprecation and migration recommendation from signin system
: copied from readme >
https://developer.android.com/identity/sign-in/legacy-gsi-migration
https://developers.google.com/identity/sign-in/ios/quick-migration-guide
Thank for ios fix which was cherrypicked from this fork : https://github.com/pillsgood/google-signin-unity
Android was migrated to use
CredentialManagerandAuthorizationClientsince GoogleSignInAccount was deprecatedHowever,
GoogleIdTokenCredentialactually not provide numeric unique ID anymore and set email as userId instead, so I have to extract jwtsubvalue from idToken (which seem like the same id as userId from GoogleSignIn of other platform)Tested in unity 2021.3.21 and unity 6000.0.4
Add UPM dependency with branch tag
https://github.com/Thaina/google-signin-unity.git#newmigration{ "dependencies": { "com.google.external-dependency-manager": "https://github.com/googlesamples/unity-jar-resolver.git?path=upm", "com.google.signin": "https://github.com/Thaina/google-signin-unity.git#newmigration", }