Skip to content

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented May 29, 2025

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 29, 2025
@mpeddada1 mpeddada1 marked this pull request as ready for review May 29, 2025 15:26
@mpeddada1 mpeddada1 requested review from suztomo and zhumin8 May 29, 2025 15:26
zhumin8
zhumin8 previously approved these changes May 29, 2025
suztomo
suztomo previously approved these changes May 29, 2025
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Other script might reference the settings.xml. In that case commenting out the lines in the settings.xml is more robust.

@mpeddada1 mpeddada1 dismissed stale reviews from suztomo and zhumin8 via 6db358f May 29, 2025 18:46
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 29, 2025
Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mpeddada1
Copy link
Contributor Author

Temporarily marking the libraries-generation and showcase tests as optional until #3810 (comment) is resolved.

@mpeddada1 mpeddada1 merged commit 5977c1f into main May 29, 2025
53 of 60 checks passed
@mpeddada1 mpeddada1 deleted the stop-maven-mirror branch May 29, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants