Skip to content

Conversation

@cloud-java-bot
Copy link
Collaborator

chore: update googleapis commit at Sat Oct 26 02:24:11 UTC 2024

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 26, 2024
diegomarquezp added a commit that referenced this pull request Oct 30, 2024
…methods (#3321)

This PR leverages the changes in
#1872 so the
generated code uses the new `java.time` methods.
All test-related changes are golden file/string changes.

#### SonarCloud complaints
The SonarCloud scanner complains about code duplication in the generator
code, although after inspection I could not find a reason for stating
so.
It also complains about showcase although the changes in this folder are
strictly golden-oriented.

#### Downstream check failures
They are of the form "could not find remote branch `vX.X.X` to
checkout". This seems not related to this PR as it is also present in
#3318
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels Nov 7, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jinseopkim0 jinseopkim0 enabled auto-merge (squash) November 14, 2024 18:31
@jinseopkim0 jinseopkim0 merged commit 0262dcb into main Nov 14, 2024
50 of 55 checks passed
@jinseopkim0 jinseopkim0 deleted the generate-libraries-main branch November 14, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants