Skip to content

fix: BaseApiTracer to noop on attemptFailed via overloaded method call #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: BaseApiTracer to noop on attemptFailed via overloaded method call #3016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b66e57
fix: `BaseApiTracer` and derived classes to noop on attemptFailed via…
diegomarquezp Jul 4, 2024
a18a81a
Merge branch 'main' into fix-downstreams-after-javatime
diegomarquezp Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions gax-java/gax/src/main/java/com/google/api/gax/tracing/BaseApiTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
*/
package com.google.api.gax.tracing;

import static com.google.api.gax.util.TimeConversionUtils.toThreetenDuration;

import com.google.api.core.InternalApi;
import com.google.api.core.ObsoleteApi;

Expand Down Expand Up @@ -105,15 +107,16 @@ public void attemptCancelled() {

@Override
public void attemptFailedDuration(Throwable error, java.time.Duration delay) {
// noop
// noop via attemptFailed(Throwable error, org.threeten.Duration)
attemptFailed(error, toThreetenDuration(delay));
}

/**
* This method is obsolete. Use {@link #attemptFailedDuration(Throwable, java.time.Duration)}
* instead.
*/
@Override
@ObsoleteApi("Use attemptFailed(Throwable, java.time.Duration) instead")
@ObsoleteApi("Use attemptFailedDuration(Throwable, java.time.Duration) instead")
public void attemptFailed(Throwable error, org.threeten.bp.Duration delay) {
// noop
}
Expand Down