Skip to content

Conversation

@JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Jun 20, 2024

In this PR:

  • Add logging module in google/iam/v1.
  • Regenerate iam.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jun 20, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jun 20, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
45.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 marked this pull request as ready for review June 20, 2024 18:45
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner June 20, 2024 18:45
@JoeWang1127 JoeWang1127 requested review from blakeli0 and lqiu96 June 20, 2024 18:45
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lqiu96
Copy link
Member

lqiu96 commented Jun 20, 2024

Do you need to add in iam/logging to the proto_path for generation_config.yaml?

GAPICs:
- proto_path: google/iam/v1
- proto_path: google/iam/v2
- proto_path: google/iam/v2beta

Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.

@lqiu96 lqiu96 removed their request for review June 20, 2024 18:50
@JoeWang1127
Copy link
Contributor Author

Do you need to add in iam/logging to the proto_path for generation_config.yaml?

GAPICs:
- proto_path: google/iam/v1
- proto_path: google/iam/v2
- proto_path: google/iam/v2beta

Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.

No need to add a proto_path because logging is a nested directory in google/iam/v1 and all protos inside the proto_path should be generated by default.

I removed the special case in generate_library.sh so that this falls to the default case.

"client_documentation": "https://cloud.google.com/java/docs/reference/proto-google-iam-v1/latest/overview",
"release_level": "stable",
"transport": "grpc",
"transport": "both",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the transport changed? Is it because this PR #2890?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now iam/v2 is used to get the transport.

@JoeWang1127 JoeWang1127 merged commit 122a493 into main Jun 20, 2024
@JoeWang1127 JoeWang1127 deleted the chore/add-iam-logging branch June 20, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants