chore: gapic-generator-java noop follow up on hermetic build scripts #2599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
reviewed
Mar 22, 2024
| GAPICs: | ||
| - proto_path: google/cloud/cloudcontrolspartner/v1 | ||
| - proto_path: google/cloud/cloudcontrolspartner/v1beta | ||
| - proto_path: google/cloud/cloudcontrolspartner/v1beta |
There was a problem hiding this comment.
any benefits of adding this line?
|
|
diegomarquezp
added a commit
that referenced
this pull request
Jun 10, 2024
…tected (#2460) Fixes #2050 Adds behavior to gracefully perform a NOOP if no services are contained in the generation request. ## Confimation in hermetic build scripts From `generate_library.sh` against `google/cloud/alloydb/connectors/v1` ``` + /usr/local/google/home/diegomarquezp/Desktop/sdk2/sdk3/sdk-platform-java/library_generation/output/protobuf-25.2/bin/protoc --experimental_allow_proto3_optional --plugin=protoc-gen-java_gapic=/usr/local/google/home/diegomarquezp/.pyenv/versions/3.11.0/lib/python3.11/site-packages/library_generation/gapic-generator-java-wrapper --java_gapic_out=metadata:/usr/local/google/home/diegomarquezp/Desktop/sdk2/sdk3/sdk-platform-java/library_generation/output/temp_preprocessed/java_gapic_srcjar_raw.srcjar.zip --java_gapic_opt=transport=grpc,rest-numeric-enums,grpc-service-config=,gapic-config=,api-service-config=google/cloud/alloydb/connectors/v1/connectors_v1.yaml google/cloud/alloydb/connectors/v1/resources.proto google/cloud/common_resources.proto Apr 05, 2024 9:33:22 PM com.google.api.generator.gapic.protoparser.Parser parse WARNING: No services found to generate. This will produce an empty zip file Apr 05, 2024 9:33:22 PM com.google.api.generator.gapic.composer.ClientLibraryPackageInfoComposer generatePackageInfo WARNING: Generating empty package info since no services were found + did_generate_gapic=true + zipinfo -t /usr/local/google/home/diegomarquezp/Desktop/sdk2/sdk3/sdk-platform-java/library_generation/output/temp_preprocessed/java_gapic_srcjar_raw.srcjar.zip Empty zipfile. + did_generate_gapic=false + [[ false == \t\r\u\e ]] ``` I made some changes to library_generation but I moved them to a follow up PR (#2599) so the checks can pass here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #2460. The checks should pass once it is merged in main and this PR is rebased/updated with the new changes.
Since GGJ will NOOP when no services are found in the passed
proto_paths, we remove theproto_onlyflag entirely so we can rely on this new behavior instead.