-
Notifications
You must be signed in to change notification settings - Fork 428
Open
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Environment details
- OS: Github Runner / Ubuntu 22.04.3
- Node.js version: 16
- npm version: n/a
release-please
version: Github Action v3
Steps to reproduce
Setup
- Have three branches--
development
,staging
, andmain
- Have
release-please
set up to run against thestaging
branch - We are squash-merging PRs and using merge commits to merge branches like
development
tostaging
/staging
tomain
/ etc.
- Dev A creates a branch off of
development
--fix/test-1
- Dev B creates a branch off of
development
--fix/test-2
fix/test-1
is squash-merged todevelopment
- It is release time--
development
is merged tostaging
release-please
runs againststaging
and generates release notes- Development continues on the
development
branch fix/test-2
is ready and is squash-merged todevelopment
- Once QA approves the release, the release PR is merged to
staging
staging
is merged intomain
main
is merged back intodevelopment
- Create another branch off of
development
--fix/test-3
- squash-merge
fix/test-3
todevelopment
- merge
development
tostaging
and wait forrelease-please
to generate a PR
That PR will not have fix/test-2
-- it appears that any PRs that are opened after we push to staging
and the release-please
action runs, but before we merge that PR to staging
are not picked up by release-please
on the next release.
Any suggestions on what might be going wrong here??
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.