Skip to content

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Oct 2, 2024

It was mentioned in #178, might as well propose something.

Mitigates #178

@mayeut mayeut requested a review from a team as a code owner October 2, 2024 18:15
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 2, 2024
@edgarrmondragon
Copy link
Contributor

Python 3.13 was published a little over a week ago. Can we get eyes on this PR?

@ostefano
Copy link

ostefano commented Jan 7, 2025

@vchudnov-g can this be merged? Thanks!

@jlaine
Copy link

jlaine commented Jan 29, 2025

This is a fantastic idea @mayeut and will save headaches with every new Python version. I do hope it gets merged soon.

@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2025
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
@parthea parthea self-assigned this Mar 17, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
@@ -26,6 +26,8 @@
CRC32C_PURE_PYTHON_EXPLICIT = "CRC32C_PURE_PYTHON" in os.environ
_FALSE_OPTIONS = ("0", "false", "no", "False", "No", None)
CRC32C_PURE_PYTHON = os.getenv("CRC32C_PURE_PYTHON") not in _FALSE_OPTIONS
# Wether or not we want to build using limited API (ABI3)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Whether is missing an h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants