perf: Replace expensive len() call with PandasBatches.total_rows in anywidget TableWidget #1937
+256
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: m
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
aee37a7 to
303c4af
Compare
tswast
reviewed
Jul 25, 2025
|
Please also update the benchmarks to use the |
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
fc38cf3 to
f643cfb
Compare
Let's use a separate PR for this request. #1949 |
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
2 times, most recently
from
e12c8ff to
f8ab27b
Compare
shuoweil
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
f8ab27b to
df85824
Compare
tswast
reviewed
Jul 31, 2025
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
df85824 to
2756968
Compare
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
7 times, most recently
from
5bc65ce to
26eb25e
Compare
bigframes-bot
removed
the
kokoro:force-run
tswast
reviewed
Aug 14, 2025
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
0d6a300 to
00f203e
Compare
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
cc7add6 to
8e9f8ee
Compare
tswast
reviewed
Aug 19, 2025
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
8e9f8ee to
536345c
Compare
product-auto-label
bot
added
size: l
shuoweil
force-pushed
the
shuowei-anywidget-remove-len-call
branch
from
79a10b8 to
0caaa52
Compare
shuoweil
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
tswast
requested changes
Sep 5, 2025
| execute_result = dataframe._block.session._executor.execute( | ||
| dataframe._block.expr, | ||
| ordered=True, | ||
| use_explicit_destination=True, |
There was a problem hiding this comment.
I don't think we want to use an explicit destination here. This would result in creating a BigQuery job every time, which is not desirable. We want to allow the faster job optional code paths.
| # The query issued by `to_pandas_batches()` already contains metadata | ||
| # about how many results there were. Use that to avoid doing an extra | ||
| # COUNT(*) query that `len(...)` would do. | ||
| self.row_count = execute_result.total_rows or 0 |
There was a problem hiding this comment.
Why did you switch it to use the execute result instead of the PandasBatches object returned by to_pandas_batches?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: Replace expensive len() call with PandasBatches.total_rows in anywidget TableWidget