chore: update benchmark logic to respect allow_large_results=False #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
product-auto-label
bot
added
size: m
Genesis929
changed the title
shuoweil
approved these changes
Mar 26, 2025
shobsi
approved these changes
Mar 26, 2025
4 tasks
shobsi
pushed a commit
that referenced
this pull request
Mar 28, 2025
…1545) * chore: update benchmark logic for 2.0 * update benchmark logic * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
With allow_large_result=True, the output should remain unchanged.
With allow_large_result=False, we will only have query count, query char count and local execution time.
Fixes #<issue_number_goes_here> 🦕