Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Feb 12, 2020

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2020
@frankyn
Copy link
Contributor

frankyn commented Feb 12, 2020

Tests didn't seem to run. Rerunning.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #124 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     63.73%   63.54%   -0.20%     
+ Complexity      548      538      -10     
============================================
  Files            30       30              
  Lines          4740     4726      -14     
  Branches        454      425      -29     
============================================
- Hits           3021     3003      -18     
- Misses         1564     1565       +1     
- Partials        155      158       +3     
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/storage/StorageBatch.java 88.00% <0.00%> (-4.00%) 13.00% <0.00%> (ø%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 61.98% <0.00%> (-3.06%) 9.00% <0.00%> (ø%)
...main/java/com/google/cloud/storage/BucketInfo.java 80.85% <0.00%> (-0.20%) 84.00% <0.00%> (ø%)
...ain/java/com/google/cloud/storage/StorageImpl.java 78.61% <0.00%> (-0.12%) 119.00% <0.00%> (-9.00%)
...e/src/main/java/com/google/cloud/storage/Blob.java 82.24% <0.00%> (-0.11%) 29.00% <0.00%> (-1.00%)
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.64% <0.00%> (+<0.01%) 1.00% <0.00%> (ø%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836977e...88c96f3. Read the comment docs.

@elharo elharo merged commit bb7a62c into master Feb 12, 2020
@elharo elharo deleted the elharo-patch-1 branch February 12, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants