Skip to content

Conversation

@JesseLovelace
Copy link
Contributor

This updates the conformance tests and adds the consistency changes necessary to make them pass, as per #84 and #85

@JesseLovelace JesseLovelace requested a review from frankyn February 4, 2020 00:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2020
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, overall LGTM I have one question before approving.

HOST_NAME,
PATH_STYLE,
VIRTUAL_HOSTED_STYLE,
BUCKET_BOUND_HOST_NAME,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jesse, I want to confirm that HOST_NAME can't be in the same way as BUCKET_BOUND_HOST_NAME. Is this accurate?

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #114 into master will increase coverage by 0.42%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #114      +/-   ##
============================================
+ Coverage      63.3%   63.73%   +0.42%     
- Complexity      528      539      +11     
============================================
  Files            30       30              
  Lines          4720     4740      +20     
  Branches        450      455       +5     
============================================
+ Hits           2988     3021      +33     
+ Misses         1571     1564       -7     
+ Partials        161      155       -6
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/storage/SignatureInfo.java 81.5% <100%> (+0.81%) 19 <0> (+2) ⬆️
...ain/java/com/google/cloud/storage/StorageImpl.java 78.72% <76.92%> (+1.91%) 119 <3> (+9) ⬆️
...rc/main/java/com/google/cloud/storage/Storage.java 80.63% <90.9%> (+0.58%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044de39...148dfc4. Read the comment docs.

Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesseLovelace JesseLovelace changed the title Update V4 signature to pass conformance tests feat: update V4 signature to pass conformance tests Feb 5, 2020
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants