Skip to content

feat: ignore provided dependencies from maven-dependency-plugin #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: ignore provided dependencies from maven-dependency-plugin #973

wants to merge 1 commit into from

Conversation

@mpeddada1
Copy link
Contributor

For #875

@mpeddada1 mpeddada1 requested a review from a team as a code owner January 27, 2025 21:12
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 27, 2025
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Jan 27, 2025 •
edited
Loading

Stacktrace:

Error: 2:936 [ERROR] The build could not read 1 project -> [Help 1]
Error: 2:936 [ERROR]   
Error: 2:936 [ERROR]   The project com.google.cloud:google-cloud-storage-parent:2.48.0 (/home/runner/work/java-shared-config/java-shared-config/sdk-platform-java/java-storage/pom.xml) has 1 error
Error: 2:937 [ERROR]     Non-resolvable import POM: The following artifacts could not be resolved: com.google.cloud:google-cloud-shared-dependencies:pom:3.42.0 (absent): Could not find artifact com.google.cloud:google-cloud-shared-dependencies:pom:3.42.0 in central (https://repo.maven.apache.org/maven2) @ line 62, column 19 -> [Help 2]

This seems to be causing issues with shared-dependencies which is specified through dependencyManagement.

@mpeddada1
Copy link
Contributor Author

@suztomo @burkedavison Revisiting #875 and now that I look at this again, I'm starting to think that ignoreNonCompile may not be the "once size fits all" solution we're looking for in terms of address the false positives in the mvn dependency:analyze command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo Awaiting requested review from suztomo

@burkedavison burkedavison Awaiting requested review from burkedavison

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1