test: add all handwritten repos to downstream check

.github/workflows/ci.yaml

@@ -85,18 +85,6 @@ jobs:
         java-version: ${{matrix.java}}
     - run: java -version
     - run: .kokoro/dependencies.sh
-  javadoc:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-java@v3
-      with:
-        distribution: temurin
-        java-version: 17
-    - run: java -version
-    - run: .kokoro/build.sh
-      env:
-        JOB_TYPE: javadoc
   lint:
     runs-on: ubuntu-latest
     steps:

.github/workflows/downstream-dependencies.yaml

@@ -3,7 +3,7 @@ on:
     branches:
     - main
   pull_request:
-name: downstream
+name: downstream-dependencies
 jobs:
   dependencies:
     runs-on: ubuntu-latest
@@ -21,7 +21,7 @@ jobs:
     - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
     - uses: actions/setup-java@v4
       with:
-        distribution: zulu
+        distribution: temurin
         java-version: ${{matrix.java}}
     - run: java -version
     - run: sudo apt-get update -y
@@ -34,7 +34,7 @@ jobs:
     - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
     - uses: actions/setup-java@v4
       with:
-        distribution: zulu
+        distribution: temurin
         java-version: 11
     - run: java -version
     - run: sudo apt-get update -y

.github/workflows/downstream-maven-plugins.yaml

@@ -7,38 +7,88 @@ on:
 # Keeping this file separate as the dependencies check would use more
 # repositories than needed this downstream check for GraalVM native image and
 # other Maven plugins.
-name: downstream
+name: downstream-maven-plugins-check
 jobs:
   build:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        java: [8, 11]
+        java: [17]
         repo:
         - java-bigquery
         - java-bigtable
+        - java-storage
+        - java-storage-nio
+        - java-spanner
+        - java-spanner-jdbc
+        - java-pubsub
+        - java-pubsublite
+        - java-logging
+        - java-logging-logback
+        - java-firestore
+        - java-datastore
+        - java-bigquerystorage
         job-type:
-        - test  # maven-surefire-plugin
         - lint  # fmt-maven-plugin and google-java-format
         - clirr # clirr-maven-plugin
-        - javadoc # maven-javadoc-plugin
-        - javadoc-with-doclet # test javadoc generation with doclet
     steps:
     - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
     - uses: actions/setup-java@v4
       with:
-        distribution: zulu
+        distribution: temurin
         java-version: ${{matrix.java}}
     - run: java -version
     - run: sudo apt-get update -y
     - run: sudo apt-get install libxml2-utils
     - run: .kokoro/client-library-check.sh ${{matrix.repo}} ${{matrix.job-type}}
+  downstream-java8:
+    # Building using Java 17 and run the tests with Java 8 runtime
+    name: "Unit test maven-plugins downstream with Java8"
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        repo:
+        - java-bigquery
+        - java-bigtable
+        - java-storage
+        - java-storage-nio
+        - java-spanner
+        - java-spanner-jdbc
+        - java-pubsub
+        - java-pubsublite
+        - java-logging
+        - java-logging-logback
+        - java-firestore
+        - java-datastore
+        - java-bigquerystorage
+        job-type:
+        - test  # maven-surefire-plugin
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-java@v3
+      with:
+        java-version: 8
+        distribution: temurin
+    - name: "Set jvm system property environment variable for surefire plugin (unit tests)"
+      # Maven surefire plugin (unit tests) allows us to specify JVM to run the tests.
+      # https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#jvm
+      run: echo "SUREFIRE_JVM_OPT=-Djvm=${JAVA_HOME}/bin/java" >> $GITHUB_ENV
+      shell: bash
+    - uses: actions/setup-java@v3
+      with:
+        java-version: 17
+        distribution: temurin
+    - run: sudo apt-get update -y
+    - run: sudo apt-get install libxml2-utils
+    - run: .kokoro/client-library-check.sh ${{matrix.repo}} ${{matrix.job-type}}
   javadoc-with-doclet:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
+        java: [17] # Run only on Java 17 as that's what c.g.c. generation uses
         repo:
         - java-bigtable
         - java-bigquery
@@ -53,12 +103,14 @@ jobs:
         - java-firestore
         - java-datastore
         - java-bigquerystorage
+        job-type:
+        - javadoc-with-doclet # test c.g.c. - specific documentation generation
     steps:
     - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
     - uses: actions/setup-java@v4
       with:
         distribution: temurin
-        java-version: 17
+        java-version: ${{matrix.java}}
     - run: java -version
     - run: sudo apt-get update -y
     - run: sudo apt-get install libxml2-utils

.kokoro/build.sh

@@ -55,10 +55,6 @@ lint)
     mvn com.coveo:fmt-maven-plugin:check -B -ntp
     RETURN_CODE=$?
     ;;
-javadoc)
-    mvn javadoc:javadoc javadoc:test-javadoc -B -ntp
-    RETURN_CODE=$?
-    ;;
 integration)
     mvn -B ${INTEGRATION_TEST_ARGS} \
       -ntp \

owlbot.py

@@ -28,12 +28,14 @@
         ".github/release-please.yml",
         ".github/workflows/auto-release.yaml",
         ".github/workflows/samples.yaml",
+        ".github/workflows/ci.yaml",
         "samples/*",
         "renovate.json",
         ".kokoro/presubmit/graalvm-native.cfg",
         ".kokoro/presubmit/graalvm-native-17.cfg",
         ".kokoro/presubmit/common.cfg",
         ".kokoro/requirements.txt",
-        ".kokoro/requirements.in"
+        ".kokoro/requirements.in",
+        ".kokoro/build.sh"
     ]
 )