fix: Add alternative property to directly create ServiceAccount #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaheb
requested changes
Oct 28, 2025
Collaborator
dsaheb
left a comment
dsaheb
left a comment
There was a problem hiding this comment.
I think we should also add the new properties to the CloudPubSubSourceConnector
src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkConnector.java
Show resolved
Hide resolved
Contributor
Done. |
diegomarquezp
previously approved these changes
Oct 31, 2025
dsaheb
requested changes
Oct 31, 2025
src/main/java/com/google/pubsublite/kafka/source/ConfigDefs.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/pubsublite/kafka/source/ConfigDefs.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/pubsub/kafka/source/CloudPubSubSourceConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/pubsub/kafka/source/CloudPubSubSourceConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkConnector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/pubsub/kafka/common/ConnectorCredentialsProvider.java
Show resolved
Hide resolved
dsaheb
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See b/437991832 for more information.
Add alternative properties to directly create ServiceAccount from properties. This is to slowly replace the general property which could create any GoogleCredential.
Add guidance for users to prefer the SA specific property.