Skip to content

Conversation

@Lance726
Copy link
Contributor

@Lance726 Lance726 commented Apr 2, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #370

If you write sample code, please follow the samples format.

@Lance726 Lance726 requested a review from a team as a code owner April 2, 2025 14:14
@google-cla
Copy link

google-cla bot commented Apr 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 2, 2025
@Lance726 Lance726 changed the title Override of the SourceTask#commitRecord(SourceRecord record, RecordMetadata metadata) method to be compatible with Kafka4.0 fix: CloudPubSubSourceTask fails to ACK messages in Kafka 4.0 due to deprecated commitRecord method Apr 2, 2025
@matt-kwong
Copy link
Collaborator

Thanks for the fix!

Could you address the failing lint check by running the following command?

mvn com.coveo:fmt-maven-plugin:format

@matt-kwong matt-kwong self-assigned this Apr 2, 2025
@matt-kwong matt-kwong added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2025
@matt-kwong matt-kwong merged commit e0f7744 into googleapis:main Apr 3, 2025
11 of 14 checks passed
@Lance726 Lance726 deleted the compatible-4.0 branch April 7, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CloudPubSubSourceTask fails to ACK messages in Kafka 4.0 due to deprecated commitRecord method

3 participants