Skip to content

Conversation

@minherz
Copy link
Contributor

@minherz minherz commented Jan 16, 2022

…OUT (#649)

Add configuration to opt-out metadata auto-population.
Add configuration to redirect appender output to stdout.
Add relevant unit tests.
Refactor unit tests.
Improve javadoc comments for methods.
Remove warnings.
Make methods with no modifier to be private.
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging-logback API. labels Jan 16, 2022
@minherz minherz marked this pull request as ready for review January 18, 2022 09:15
@minherz minherz requested review from a team as code owners January 18, 2022 09:15
testLogger.log("test");
}
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline?

<flushLevel>WARNING</flushLevel>

<!-- Optional: auto detects on App Engine Flex, Standard, GCE and GKE, defaults to "global". See supported resource types -->
<!-- Optional: defaults to ASYNC -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you supposing to edit README?

@minherz minherz merged commit 6530782 into main Jan 18, 2022
@minherz minherz deleted the structured_logging branch January 18, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/java-logging-logback API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

structured logging: print structured logs to stdout

3 participants