Skip to content

feat: add graal native image profile for logback library #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 16, 2024
Merged

feat: add graal native image profile for logback library #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f155d99
feat:add graal native image profile for logback library
Jan 11, 2024
0022c4d
feat:add graal native image profile for logback library
Jan 11, 2024
dbfba42
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 11, 2024
1f77719
Add comment for skipped mock tests
Jan 16, 2024
4e15100
Merge branch 'cindy/native-profile' of https://github.com/googleapis/…
Jan 16, 2024
b744a98
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 16, 2024
ac6150a
Merge branch 'main' into cindy/native-profile
cindy-peng Jan 16, 2024
839e663
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .kokoro/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ integration)
RETURN_CODE=$?
;;
graalvm)
# Run Unit and Integration Tests with Native Image. Skip tests that use mocking libs
mvn -B ${INTEGRATION_TEST_ARGS} -ntp -Pnative test "-Dtest=!LoggingAppenderTest"
# Run Unit and Integration Tests with Native Image
mvn -B ${INTEGRATION_TEST_ARGS} -ntp -Pnative test
RETURN_CODE=$?
;;
graalvm17)
# Run Unit and Integration Tests with Native Image
mvn -B ${INTEGRATION_TEST_ARGS} -ntp -Pnative test "-Dtest=!LoggingAppenderTest"
mvn -B ${INTEGRATION_TEST_ARGS} -ntp -Pnative test
RETURN_CODE=$?
;;
samples)
Expand Down
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@ If you are using Maven, add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-logging-logback</artifactId>
<version>0.130.29-alpha</version>
<version>0.130.30-alpha</version>
</dependency>
```

If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-logging-logback:0.130.29-alpha'
implementation 'com.google.cloud:google-cloud-logging-logback:0.130.30-alpha'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-logging-logback" % "0.130.29-alpha"
libraryDependencies += "com.google.cloud" % "google-cloud-logging-logback" % "0.130.30-alpha"
```
<!-- {x-version-update-end} -->

Expand Down Expand Up @@ -299,7 +299,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-logging-logback/java11.html
[stability-image]: https://img.shields.io/badge/stability-preview-yellow
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-logging-logback.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-logging-logback/0.130.29-alpha
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-logging-logback/0.130.30-alpha
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
3 changes: 1 addition & 2 deletions owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
'.github/blunderbuss.yml',
'CONTRIBUTING.md',
'.github/auto-label.yaml',
".github/release-please.yml",
".kokoro/build.sh"
".github/release-please.yml"
])

# --------------------------------------------------------------------------
Expand Down
9 changes: 9 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,13 @@
</plugin>
</plugins>
</build>
<profiles>
<profile>
<id>native</id>
<properties>
<!-- Skip native image tests that use mocking libs to avoid loading classes at runtime. -->
<test>!LoggingAppenderTest</test>
Copy link
Contributor

@kolea2 kolea2 Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-add the comment that was in the build.sh file about why we're skipping this

Copy link
Contributor Author

@cindy-peng cindy-peng Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-add the comment that was in the build.sh file about why we're skipping this

Good feedback! Added the comment.

</properties>
</profile>
</profiles>
</project>