Skip to content

fix: Use ImmutableMap.Builder.buildOrThrow() instead of build(). #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: Use ImmutableMap.Builder.buildOrThrow() instead of build(). #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-datastore/src/main/java/com/google/cloud/datastore/GqlQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ public Map<String, Object> getNamedBindings() {
for (Map.Entry<String, Binding> binding : namedBindings.entrySet()) {
builder.put(binding.getKey(), binding.getValue().getCursorOrValue());
}
return builder.build();
return builder.buildOrThrow();
}

/** Returns an immutable list of positional bindings (using original order). */
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-datastore/src/main/java/com/google/cloud/datastore/ReadOption.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ static Map<Class<? extends ReadOption>, ReadOption> asImmutableMap(ReadOption...
for (ReadOption option : options) {
builder.put(option.getClass(), option);
}
return builder.build();
return builder.buildOrThrow();
}
}
2 changes: 1 addition & 1 deletion google-cloud-datastore/src/main/java/com/google/cloud/datastore/ValueType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public enum ValueType {
builder.put(fieldId, valueType);
}
}
DESCRIPTOR_TO_TYPE_MAP = builder.build();
DESCRIPTOR_TO_TYPE_MAP = builder.buildOrThrow();
}

<V, P extends Value<V>, B extends ValueBuilder<V, P, B>> ValueType(
Expand Down
4 changes: 2 additions & 2 deletions google-cloud-datastore/src/test/java/com/google/cloud/datastore/ValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public class ValueTest {
.put(ValueType.RAW_VALUE, new Object[] {RawValue.class, RAW_VALUE.get()})
.put(ValueType.LAT_LNG, new Object[] {LatLngValue.class, LAT_LNG_VALUE.get()})
.put(ValueType.STRING, new Object[] {StringValue.class, STRING_VALUE.get()})
.build();
.buildOrThrow();

private ImmutableMap<ValueType, Value<?>> typeToValue;

Expand Down Expand Up @@ -110,7 +110,7 @@ public void setUp() throws Exception {
assertTrue("Could not find an of method for " + valueClass, found);
}
}
typeToValue = builder.build();
typeToValue = builder.buildOrThrow();
}

@Test
Expand Down