UriTemplate expansion reserved ("+") and fragment("#") should not encode already percent encoded parts

[alexander-asenov]

According to RFC 6570 Section 3.2.1: reserved ("+") and fragment ("#") expansions allow the set of characters in the union of ( unreserved / reserved / pct-encoded ) to be passed through without pct-encoding, whereas all other expression types allow only unreserved characters to be passed through without pct-encoding.

But currently pct-encoded characters are being re-encoded. Meaning that {+var} and {#var} should not re-encode already pct-encoded triplets, but currently the implementation does that:

Code example

    @Test
    void textUriTemplate_shouldNotEncodeAlreadyPercentEncodedTriplets() {
        String template = "{+var}";
        Map<String, Object> variables = Map.of("var", "admin%2F");

        String result = UriTemplate.expand(template, variables, false);

        // Expecting the result to be "admin%2F" without encoding
        Assertions.assertEquals("admin%2F", result, "The encoded character should not be changed.");
    }

Expected : admin%2F
Actual   : admin%252F

Requested feature:

• Extend the Level 2 templates support to not re-encode already percent-encoded triplets (e.g., %20 should remain %20) when reserved ("+") and fragment ("#") expansions are used.

[suztomo]

@ldetmer I didn't check this issue. The last time I checked a similar issue, I compared the behavior between this library and Python's uritemplate #1844 (comment).

[diegomarquezp]

Hi @alexander-asenov thank you for raising this concern. Please note that in order ensure fast response times, you can use our Support Hub if you have a support plan with us.