Skip to content

Conversation

@busunkim96
Copy link
Contributor

Fixes #46 and #45.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2019
@busunkim96
Copy link
Contributor Author

@jay0lee Would you be able to review this?

jay0lee added a commit to GAM-team/GAM that referenced this pull request Jun 18, 2019
Next release may break code_verifier auto-gen based on
googleapis/google-auth-library-python-oauthlib#48 so we lock at 0.4.0 for now.
@busunkim96 busunkim96 changed the title Remove auto-generation of code_verifier. Don't auto-generate code_verifier by default. Jun 18, 2019
@busunkim96
Copy link
Contributor Author

busunkim96 commented Jun 18, 2019

@jay0lee @tamaroth PTAL.

(I still need to be fix some lint errors)

@busunkim96 busunkim96 requested a review from theacodes June 24, 2019 19:57
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 24, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@busunkim96 busunkim96 merged commit b57e129 into master Aug 26, 2019
@parthea parthea deleted the fix-code-verifier branch October 1, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code_verify is not automatically generated if not passed as an argument.

7 participants