Skip to content

Conversation

@snu5mumr1k
Copy link
Contributor

@snu5mumr1k snu5mumr1k commented Jul 28, 2021

  1. Acknowledge more detailed error reporting when parsing JSON.
  2. Remove unnecessary (for what I understand) circular dependency.
  3. Remove excess errors from comparison examples as they seem not to be relevant anymore (even on earlier versions of vim).

fixes #239

@google-cla google-cla bot added the cla: yes label Jul 28, 2021
@snu5mumr1k snu5mumr1k marked this pull request as ready for review July 31, 2021 15:32
@snu5mumr1k
Copy link
Contributor Author

I'll need to also update the docs.
How does one regenerate them?

@dbarnett
Copy link
Contributor

I'll need to also update the docs. How does one regenerate them?

Install vimdoc from https://github.com/google/vimdoc (from the deb at https://github.com/google/vimdoc/releases/tag/v0.7.0 on Debian-based Linux systems or with python3 setup.py install), and then run vimdoc . in the plugin path. I can pull the changes and regen docs on my end if you have trouble.

BTW, did git mark the files as copied? It'd be helpful to have that with so much copied code, but in GitHub the diffs don't show comparison to the original.

Hide actual implementation of maktaba/plugin.vim in an internal lib, so we can call it from maktaba.vim.
@snu5mumr1k
Copy link
Contributor Author

BTW, did git mark the files as copied?

Yeah, I forgot how annoying git can be. It took me a couple of rebases and force pushes to make everything better.

I would like to set up github actions, not to deal with travis failing, so let's submit that pr first.

Copy link
Contributor

@dbarnett dbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! THANK YOU for seeing this change through! Merging…

@dbarnett dbarnett merged commit 92b8483 into google:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maktaba plugin bootstrap can fail with Unknown function: maktaba#Maktaba

2 participants