-
Notifications
You must be signed in to change notification settings - Fork 41
Make maktaba and its tests compatible with vim >= 8.2.2434. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'll need to also update the docs. |
Install vimdoc from https://github.com/google/vimdoc (from the deb at https://github.com/google/vimdoc/releases/tag/v0.7.0 on Debian-based Linux systems or with BTW, did git mark the files as copied? It'd be helpful to have that with so much copied code, but in GitHub the diffs don't show comparison to the original. |
Hide actual implementation of maktaba/plugin.vim in an internal lib, so we can call it from maktaba.vim.
871de14 to
37bdd58
Compare
Yeah, I forgot how annoying git can be. It took me a couple of rebases and force pushes to make everything better. I would like to set up github actions, not to deal with travis failing, so let's submit that pr first. |
dbarnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! THANK YOU for seeing this change through! Merging…
fixes #239