Skip to content

331572594: (fix) [a11Y] GAR 1.13 The firmware field validation #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024
Merged

331572594: (fix) [a11Y] GAR 1.13 The firmware field validation #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...app/pages/testrun/components/progress-initiate-form/progress-initiate-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,21 @@
[class.hidden]="selectedDevice === null"
appearance="outline">
<mat-label>Firmware</mat-label>
<input formControlName="firmware" matInput #firmwareInput />
<input
class="firmware-input"
formControlName="firmware"
matInput
#firmwareInput />
<mat-hint>Please enter device firmware</mat-hint>
<mat-error
*ngIf="firmware.hasError('invalid_format')"
role="alert"
aria-live="assertive">
<span
>Please, check. The firmware value must be a maximum of 64 characters.
Only letters, numbers, and accented letters are permitted.</span
>
</mat-error>
<mat-error *ngIf="firmware.errors?.['required']">
<span>Firmware is <strong>required</strong></span>
</mat-error>
Expand Down
23 changes: 23 additions & 0 deletions .../pages/testrun/components/progress-initiate-form/progress-initiate-form.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,29 @@ describe('ProgressInitiateFormComponent', () => {
).toEqual(true);
});

it('should have "invalid_format" error when field does not meet validation rules', () => {
[
'very long value very long value very long value very long value very long value very long value very long value',
'!as&@3$',
].forEach(value => {
const firmware: HTMLInputElement = compiled.querySelector(
'.firmware-input'
) as HTMLInputElement;
firmware.value = value;
firmware.dispatchEvent(new Event('input'));
component.firmware.markAsTouched();
fixture.detectChanges();

const firmwareError = compiled.querySelector('mat-error')?.innerHTML;
const error = component.firmware.hasError('invalid_format');

expect(error).toBeTruthy();
expect(firmwareError).toContain(
'The firmware value must be a maximum of 64 characters. Only letters, numbers, and accented letters are permitted.'
);
});
});

describe('when selectedDevice is present and firmware is filled', () => {
beforeEach(() => {
component.firmware.setValue('firmware');
Expand Down