Skip to content

Conversation

karwa
Copy link

@karwa karwa commented Feb 9, 2022

This PR does 2 things:

  1. Splits warmup reporting, if warmup iterations are specified:
karl@Karls-MBP Benchmarks % ./.build/release/WebURLBenchmark --filter "Foundation" --warmup-iterations 20000
Warming up... Running FoundationCompat.ToWeb: AverageURLs... Done! (3944.60 ms)
Warming up... Running FoundationCompat.ToWeb: IPv4... Done! (4075.08 ms)
Warming up... Running FoundationCompat.ToWeb: IPv6... Done! (3421.14 ms)

karl@Karls-MBP Benchmarks % ./.build/release/WebURLBenchmark --filter "Foundation"                          
Running FoundationCompat.ToWeb: AverageURLs... Done! (1496.40 ms)
Running FoundationCompat.ToWeb: IPv4... Done! (2351.41 ms)
Running FoundationCompat.ToWeb: IPv6... Done! (1448.58 ms)
  1. Adds os_signpost reporting on platforms where OSLog is available, so Instruments can show which benchmark is running at which time, and similarly split that in to warmup/benchmark sections:

image

image

@karwa
Copy link
Author

karwa commented Feb 9, 2022

Ping @compnerd @shabalind

Would you mind triggering the tests and reviewing? Whenever you get a chance, no rush. Thanks.

@compnerd
Copy link
Contributor

Would you mind splitting this up into two separate changes? Addition of the signposts should be simple and straight forward, and then we can look at the structural changes for the split warmup separately.

@shabalind
Copy link
Collaborator

shabalind commented May 10, 2022

Hi @karwa, any updates on splitting this change as requested by @compnerd earlier in this thread?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants